Skip to content

fix: use --prefix instead of --dir for npm provider #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix: use --prefix instead of --dir for npm provider #187

merged 1 commit into from
Apr 28, 2025

Conversation

Strum355
Copy link
Member

Description

Also added type signature overloads for stack analysis function to narrow the return type based on if HTML report is requested or not

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

Anything else?

@Strum355 Strum355 requested a review from ruromero April 28, 2025 10:18
ruromero
ruromero approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Strum355 Strum355 enabled auto-merge (squash) April 28, 2025 10:21
@Strum355 Strum355 merged commit 0c14597 into trustification:main Apr 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruromero ruromero ruromero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strum355 @ruromero