Skip to content

refactor: remove self-generated openapi-spec #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2025

Conversation

ruromero
Copy link
Collaborator

@ruromero ruromero commented May 13, 2025

Description

Remove dependency with self generated openapi spec and rely on the exhort-api-spec generated library

Fix: #199

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

@ruromero ruromero requested a review from Strum355 May 13, 2025 11:23
@ruromero ruromero force-pushed the refactor/schema-gen branch 2 times, most recently from d901533 to cb64549 Compare May 13, 2025 13:39
@ruromero ruromero force-pushed the refactor/schema-gen branch from cb64549 to a580bc4 Compare May 13, 2025 13:40
ruromero added 3 commits May 13, 2025 16:33
Signed-off-by: Ruben Romero Montes <[email protected]>
Signed-off-by: Ruben Romero Montes <[email protected]>
Strum355
Strum355 previously approved these changes May 14, 2025
Copy link
Member

@Strum355 Strum355 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment about @overload, the jsdoc is good to go 👍

Signed-off-by: Ruben Romero Montes <[email protected]>
@ruromero ruromero force-pushed the refactor/schema-gen branch from 2a264d7 to 6f58ae7 Compare May 14, 2025 14:28
@ruromero ruromero enabled auto-merge (squash) May 14, 2025 14:34
@ruromero ruromero disabled auto-merge May 14, 2025 15:39
@ruromero ruromero merged commit 2f0ac69 into trustification:main May 14, 2025
4 checks passed
@ruromero ruromero deleted the refactor/schema-gen branch May 14, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use exhort-api-spec instead of generating the javascript model
2 participants