Allow searching by CPE and provide CPE information #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimFuller-RedHat
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
this is a big update - some of it concerned with much better code layout and I appreciate you taking the time/effort to clean up my crappy code ;) ... otherwise everything makes sense LGTM ... I would rather get this in so I can test at scale to make sure (before we do a new release).
ctron
force-pushed
the
feature/cpe_ref_1
branch
2 times, most recently
from
fbcc8dc to
7634f28
Compare
Also, get rid of the central analysis graph instance.
ctron
force-pushed
the
feature/cpe_ref_1
branch
from
7afe830 to
7f36cdf
Compare
This main motivation was to have multiple purls/cpes available. I guess this also fixed other issues.
JimFuller-RedHat
approved these changes
Jan 17, 2025
jcrossley3
reviewed
Jan 17, 2025
| @@ -1,3 +1,4 @@ | |||
| use trustify_module_analysis::service::AnalysisService; | |||
There was a problem hiding this comment.
I've had other reasons for wanting to move analysis beneath fundamental, fwiw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1137