Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TC-2165 OSV loader: set properly VersionScheme in version_range #1157

Merged
merged 1 commit into from
Jan 20, 2025
Merged

TC-2165 OSV loader: set properly VersionScheme in version_range #1157

merged 1 commit into from
Jan 20, 2025

Conversation

mrizzi
Copy link
Collaborator

@mrizzi mrizzi commented Jan 17, 2025

Enhanced OSV loader to manage the (range)type and ecosystem properly when dealing with the version_range.version_scheme_id value.
In this way the GHSA advisories in ds3 correlate with the quarkus-bom and in this regard a test has been added.

@mrizzi mrizzi requested a review from dejanb January 17, 2025 17:49
@mrizzi mrizzi force-pushed the osv-version-range-scheme branch from bdd91e4 to 6259419 Compare January 17, 2025 18:05
dejanb
dejanb approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@dejanb dejanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great

@dejanb dejanb added this pull request to the merge queue Jan 20, 2025
Merged via the queue into trustification:main with commit e3783b2 Jan 20, 2025
1 check passed
@mrizzi mrizzi deleted the osv-version-range-scheme branch January 20, 2025 10:54
@mrizzi mrizzi changed the title OSV loader: set properly VersionScheme in version_range TC-2165 OSV loader: set properly VersionScheme in version_range Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctron ctron ctron approved these changes

@dejanb dejanb dejanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrizzi @dejanb @ctron