Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve graph loading performance #1175

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Jan 21, 2025

No description provided.

@ctron ctron force-pushed the feature/agraph_perf_1 branch from f1dc297 to a19cced Compare January 21, 2025 16:04
@ctron ctron force-pushed the feature/agraph_perf_1 branch from a19cced to e9292a9 Compare January 21, 2025 16:10
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite a lot of good changes ... I did go through in detail though would like to see this in main (once tests pass) and do further testing, thx! LGTM

@ctron
Copy link
Contributor Author

ctron commented Jan 21, 2025

Here are some numbers:

Before: Loading took: 13s 114ms 667us 84ns 
 After: Loading took: 1s 750ms 127us 55ns

Sure It Corrupts Your Files,
But Look How Fast It Is!

@ctron ctron force-pushed the feature/agraph_perf_1 branch from e9292a9 to 1dd006f Compare January 21, 2025 16:18
@ctron ctron marked this pull request as ready for review January 21, 2025 16:19
@ctron ctron force-pushed the feature/agraph_perf_1 branch from 97442a4 to ddd620b Compare January 21, 2025 17:13
@ctron ctron force-pushed the feature/agraph_perf_1 branch from ddd620b to db51bd2 Compare January 21, 2025 17:14
@ctron ctron enabled auto-merge January 21, 2025 17:19
@ctron ctron added this pull request to the merge queue Jan 21, 2025
Merged via the queue into trustification:main with commit cd155b7 Jan 21, 2025
1 check passed
@ctron ctron deleted the feature/agraph_perf_1 branch January 21, 2025 17:41
Comment on lines -578 to +593
let child = "pkg:generic/[email protected]?download_url=https://pkgs.devel.redhat.com/repo/openssl/openssl-3.0.7-hobbled.tar.gz/sha512/1aea183b0b6650d9d5e7ba87b613bb1692c71720b0e75377b40db336b40bad780f7e8ae8dfb9f60841eeb4381f4b79c4c5043210c96e7cb51f90791b80c8285e/openssl-3.0.7-hobbled.tar.gz&checksum=SHA-512:1aea183b0b6650d9d5e7ba87b613bb1692c71720b0e75377b40db336b40bad780f7e8ae8dfb9f60841eeb4381f4b79c4c5043210c96e7cb51f90791b80c8285e";
let child = "pkg:generic/[email protected]?checksum=SHA-512:1aea183b0b6650d9d5e7ba87b613bb1692c71720b0e75377b40db336b40bad780f7e8ae8dfb9f60841eeb4381f4b79c4c5043210c96e7cb51f90791b80c8285e&download_url=https://pkgs.devel.redhat.com/repo/openssl/openssl-3.0.7-hobbled.tar.gz/sha512/1aea183b0b6650d9d5e7ba87b613bb1692c71720b0e75377b40db336b40bad780f7e8ae8dfb9f60841eeb4381f4b79c4c5043210c96e7cb51f90791b80c8285e/openssl-3.0.7-hobbled.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it that allows you to assume the order of the qualifiers is invariant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants