Skip to content

[A3] WIP: Optimize ratifyMint gas usage #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[A3] WIP: Optimize ratifyMint gas usage #1209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/contracts-por/contracts/TokenControllerV3.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,14 +369,14 @@ contract TokenControllerV3 {
address _to,
uint256 _value
) external mintNotPaused onlyMintRatifierOrOwner {
MintOperation memory op = mintOperations[_index];
MintOperation storage op = mintOperations[_index];
require(op.to == _to, "to address does not match");
require(op.value == _value, "amount does not match");
require(!mintOperations[_index].approved[msg.sender], "already approved");
mintOperations[_index].approved[msg.sender] = true;
mintOperations[_index].numberOfApproval = mintOperations[_index].numberOfApproval.add(1);
require(!op.approved[msg.sender], "already approved");
op.approved[msg.sender] = true;
op.numberOfApproval = op.numberOfApproval.add(1);
emit MintRatified(_index, msg.sender);
if (hasEnoughApproval(mintOperations[_index].numberOfApproval, _value)) {
if (hasEnoughApproval(op.numberOfApproval, _value)) {
finalizeMint(_index);
}
}
Expand Down