Add discord domain & update validation links to support multiple domains#108
Open
madtocc wants to merge 3 commits into
Open
Add discord domain & update validation links to support multiple domains#108madtocc wants to merge 3 commits into
madtocc wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format for Discord invitation links has recently transitioned from discord.com/invite to discord.gg/invite. Due to this change, newly established Discord groups face challenges linking their socials in asset PRs because of domain restrictions. This PR aims to address and resolve that limitation to ensure a smoother experience for asset contributors on TrustWallet's assets repository.
Changes:
Modified the "discord" key's value structure, transitioning from a single string to a slice of strings to accommodate multiple valid prefixes.
Adjusted the validation logic to correctly handle and validate the list of potential prefixes.
Introduced new tests to ensure the ValidateLinks function remains robust and now encompasses the latest changes.