[CodeQuality]: Enable sonarcloud on CI run (#2676)

.github/workflows/linux-ci-sonarcloud.yml

@@ -0,0 +1,49 @@
+name: Linux CI SonarCloud
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+    runs-on: ubuntu-22.04
+    steps:
+    - uses: actions/checkout@v2
+    - name: Install system dependencies
+      run: |
+        # build-essential clang-14 libc++-dev libc++abi-dev ruby-full cmake
+        sudo apt-get update && sudo apt-get install ninja-build lcov llvm-14 clang-tidy-14 libboost-all-dev --fix-missing
+    - name: Cache internal dependencies
+      id: internal_cache
+      uses: actions/[email protected]
+      with:
+        path: build/local
+        key: ${{ runner.os }}-internal-${{ hashFiles('tools/install-dependencies') }}
+    - name: Install internal dependencies
+      run: |
+        tools/install-dependencies
+      env:
+        CC: /usr/bin/clang
+        CXX: /usr/bin/clang++
+      if: steps.internal_cache.outputs.cache-hit != 'true'
+    - name: Code generation
+      run: |
+        tools/generate-files
+      env:
+        CC: /usr/bin/clang
+        CXX: /usr/bin/clang++
+    - name: CMake (coverage/clang-tidy/clang-asan)
+      run: |
+        cmake -H. -Bbuild -DCMAKE_BUILD_TYPE=Debug -DTW_CODE_COVERAGE=ON -DTW_ENABLE_CLANG_TIDY=ON -DTW_CLANG_ASAN=ON -GNinja
+        cat build/compile_commands.json
+      env:
+        CC: /usr/bin/clang
+        CXX: /usr/bin/clang++
+    - name: SonarCloud Scan
+      run: |
+        ./tools/sonarcloud-analysis
+      env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

sonar-project.properties

@@ -0,0 +1,7 @@
+sonar.organization=trustwallet
+sonar.projectKey=TrustWallet_wallet-core
+sonar.cfamily.compile-commands=build/compile_commands.json
+sonar.cfamily.reportingCppStandardOverride=c++20
+sonar.cfamily.cache.enabled=false
+sonar.lang.patterns.cpp=**/*.cc,**/*.cpp,**/*.cxx,**/*.c++,**/*.hh,**/*.hpp,**/*.hxx,**/*.h++,**/*.ipp,**/*.h
+sonar.lang.patterns.c=**/*.c

src/HDWallet.cpp

@@ -283,7 +283,7 @@ std::string serialize(const HDNode* node, uint32_t fingerprint, uint32_t version
 bool deserialize(const std::string& extended, TWCurve curve, Hash::Hasher hasher, HDNode* node) {
     TW::memzero(node);
     const char* curveNameStr = curveName(curve);
-    if (curveNameStr == nullptr || ::strlen(curveNameStr) == 0) {
+    if (curveNameStr == nullptr || std::string(curveNameStr).empty()) {
         return false;
     }
     node->curve = get_curve_by_name(curveNameStr);

src/Mnemonic.cpp

@@ -32,7 +32,7 @@ bool Mnemonic::isValidWord(const std::string& word) {
     // (i.e., no early exit on match)
     auto found = false;
     for (const char* const* w = mnemonicWordlist(); *w != nullptr; ++w) {
-        if (strlen(*w) == len && strncmp(*w, wordC, len) == 0) {
+        if (std::string(*w).size() == len && strncmp(*w, wordC, len) == 0) {
             found = true;
         }
     }

src/Result.h

@@ -122,10 +122,10 @@ struct Result {
     E error() const { return get<E>(); }
 
     /// Returns a new success result with the given payloadd.
-    static Result<T, E> success(T&& val) { return Result(Types::Success<T>(std::forward<T>(val))); }
+    static Result<T, E> success(T&& val) { return Result(Types::Success<T>(std::move(val))); }
 
     /// Returns a new failure result with the given error.
-    static Result<T, E> failure(E&& val) { return Result(Types::Failure<E>(std::forward<E>(val))); }
+    static Result<T, E> failure(E&& val) { return Result(Types::Failure<E>(std::move(val))); }
 
     static Result<T, E> failure(E& val) { return Result(Types::Failure<E>(val)); }
 
@@ -171,7 +171,7 @@ struct Result<void, E> {
 
     /// Returns a new failure result with the given error.
     static Result<void, E> failure(E&& val) {
-        return Result(Types::Failure<E>(std::forward<E>(val)));
+        return Result(Types::Failure<E>(std::move(val)));
     }
 
     operator bool() const { return success_; }

src/interface/TWTransactionCompiler.cpp

@@ -31,13 +31,15 @@ TWData *_Nonnull TWTransactionCompilerBuildInput(enum TWCoinType coinType, TWStr
     return TWDataCreateWithBytes(result.data(), result.size());
 }
 
-std::vector<Data> createFromTWDataVector(const struct TWDataVector* _Nonnull dataVector) {
+static std::vector<Data> createFromTWDataVector(const struct TWDataVector* _Nonnull dataVector) {
     std::vector<Data> ret;
     const auto n = TWDataVectorSize(dataVector);
-    for (auto i = 0ul; i < n; ++i) {
-        auto elem = TWDataVectorGet(dataVector, i);
-        ret.push_back(*(static_cast<const Data*>(elem)));
-        TWDataDelete(elem);
+    for (auto i = 0uL; i < n; ++i) {
+        const auto* const elem = TWDataVectorGet(dataVector, i);
+        if (const auto* const data = reinterpret_cast<const Data *>(elem); data) {
+            ret.emplace_back(*data);
+            TWDataDelete(elem);
+        }
     }
     return ret;
 }

tools/sonar-scanner.properties

@@ -0,0 +1,9 @@
+#Configure here general information about the environment, such as SonarQube server connection details for example
+#No information about specific project should appear here
+
+#----- Default SonarQube server
+sonar.host.url=https://sonarcloud.io/
+
+#----- Default source code encoding
+#sonar.sourceEncoding=UTF-8
+

tools/sonarcloud-analysis

@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+
+TARGET=sonar-scanner-cli-4.7.0.2747-linux.zip
+TARGET_DIR=sonar-scanner-4.7.0.2747-linux
+curl https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/${TARGET} --output ${TARGET}
+unzip ${TARGET}
+cp tools/sonar-scanner.properties ${TARGET_DIR}/conf
+chmod +x ${TARGET_DIR}/bin/sonar-scanner
+./${TARGET_DIR}/bin/sonar-scanner