Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos]: Add ability to sign direct with TxBody bytes only #4202

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Add ability to sign direct with TxBody bytes only.
In other words, generate AuthInfo from SigningInput parameters if SignDirect.auth_info_bytes not provided.

How to test

Run Rust tests

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

* Generate `AuthInfo` from `SigningInput` parameters if `SignDirect.auth_info_bytes` empty
Copy link

github-actions bot commented Jan 8, 2025

Binary size comparison

➡️ aarch64-apple-ios:

- 12.52 MB
+ 12.53 MB 	 +7 KB

➡️ aarch64-apple-ios-sim:

- 12.53 MB
+ 12.53 MB 	 +7 KB

➡️ aarch64-linux-android:

- 16.17 MB
+ 16.18 MB 	 +10 KB

➡️ armv7-linux-androideabi:

- 13.79 MB
+ 13.79 MB 	 +7 KB

➡️ wasm32-unknown-emscripten:

- 11.47 MB
+ 11.47 MB 	 +6 KB

@satoshiotomakan satoshiotomakan merged commit 37a5e6b into master Jan 9, 2025
14 checks passed
@satoshiotomakan satoshiotomakan deleted the s/cosmos-sign-direct-with-tx-body branch January 9, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants