Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android]: Add support for Android devices with 16kb page size #4212

Merged
merged 14 commits into from
Jan 16, 2025

Conversation

satoshiotomakan
Copy link
Collaborator

Description

https://android-developers.googleblog.com/2024/08/adding-16-kb-page-size-to-android.html
https://developer.android.com/guide/practices/page-sizes

How to test

Run Android tests

Types of changes

  • Upgrade Android SDK to 35
  • Upgrade Android NDK to 28
  • Upgrade AGP to 8.7
  • Upgrade nlohmann::json to 3.11.3

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Jan 14, 2025

Binary size comparison

➡️ aarch64-apple-ios: 12.53 MB

➡️ aarch64-apple-ios-sim: 12.54 MB

➡️ aarch64-linux-android: 16.19 MB

➡️ armv7-linux-androideabi: 13.80 MB

➡️ wasm32-unknown-emscripten: 11.48 MB

@eakurnikov eakurnikov marked this pull request as draft January 15, 2025 08:41
@eakurnikov eakurnikov marked this pull request as ready for review January 15, 2025 08:41
@eakurnikov eakurnikov force-pushed the s/android-16kb-page branch 2 times, most recently from 95868b7 to 1601d35 Compare January 15, 2025 12:02
@satoshiotomakan satoshiotomakan merged commit c465eb6 into master Jan 16, 2025
12 checks passed
@satoshiotomakan satoshiotomakan deleted the s/android-16kb-page branch January 16, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants