Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sui]: Support Sui sign personal message #4223

Merged
merged 4 commits into from
Jan 20, 2025
Merged

[Sui]: Support Sui sign personal message #4223

merged 4 commits into from
Jan 20, 2025

Conversation

10gic
Copy link
Contributor

@10gic 10gic commented Jan 17, 2025

Description

Support Sui SignPersonalMessage, see: https://sdk.mystenlabs.com/dapp-kit/wallet-hooks/useSignPersonalMessage

How to test

Run Rust, C++, iOS, Android tests

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@10gic 10gic changed the title Support Sui sign personal message [Sui]: Support Sui sign personal message Jan 17, 2025
@10gic
Copy link
Contributor Author

10gic commented Jan 20, 2025

Hi @satoshiotomakan, could you please find some time to help me review the code?

satoshiotomakan
satoshiotomakan approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @10gic
Only one question

rust/chains/tw_sui/src/modules/message_signer.rs Show resolved Hide resolved
@satoshiotomakan satoshiotomakan merged commit 48147df into trustwallet:master Jan 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoshiotomakan satoshiotomakan satoshiotomakan approved these changes

@Milerius Milerius Awaiting requested review from Milerius Milerius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@10gic @satoshiotomakan