Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup yaml file if its invalid #4242

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Cleanup yaml file if its invalid #4242

merged 2 commits into from
Jan 28, 2025

Conversation

gupnik
Copy link
Collaborator

@gupnik gupnik commented Jan 28, 2025

Description

In some CI builds, it seems that the binding yaml file exists but is empty. This PR ensures that the macro handles an invalid file.

How to test

CI builds should work

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

Binary size comparison

➡️ aarch64-apple-ios: 12.92 MB

➡️ aarch64-apple-ios-sim: 12.92 MB

➡️ aarch64-linux-android: 16.78 MB

➡️ armv7-linux-androideabi: 14.16 MB

➡️ wasm32-unknown-emscripten: 11.89 MB

@satoshiotomakan satoshiotomakan merged commit d08dfdd into master Jan 28, 2025
14 checks passed
@satoshiotomakan satoshiotomakan deleted the gupnik/yaml-fix branch January 28, 2025 09:37
andreibancioiu added a commit to multiversx/wallet-core that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants