Rewrite LiveTranslationFeature to TCA #97
+684
−465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I'll check this PR after the conference. It seems to be what I desired 😍 |
d-date
reviewed
Apr 14, 2025
| } | ||
| case .view(.connectStream): | ||
| return .run { send in | ||
| await send(.connectChatStream) |
There was a problem hiding this comment.
Call function instead. Sending other action in send causes performance issue.
d-date
reviewed
Apr 15, 2025
| } | ||
|
|
||
| extension LiveTranslationServiceClient: DependencyKey { | ||
| static func live() -> Self { |
Comment on lines
16
to
19
| var liveTranslation = LiveTranslation.State( | ||
| roomNumber: ProcessInfo.processInfo.environment["LIVE_TRANSLATION_KEY"] | ||
| ?? (Bundle.main.infoDictionary?["Live translation room number"] as? String) ?? "" | ||
| ) |
There was a problem hiding this comment.
Extract to BulidConfig, which defined as Dependency Client.
See how it works at isowords:
https://github.com/pointfreeco/isowords/tree/main/Sources/Build
Build is preserved in .gitignore so use BuildConfig instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to rewrite LiveTranslationFeature into TCA (aligning it with the architecture of other features).
And also add #93 and #95 features.
480p.mov
I found an issue where the simulator build doesn’t run the translation after stopping debugging. However, this can also be reproduced on the main branch, so it doesn’t seem to be a critical problem.