Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More static analysis fixes #205

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Conversation

toxieainc
Copy link
Contributor

and one more in the hope of fixing #178 or #203, unfortunately no luck with those

@dukeeeey
Copy link
Collaborator

dukeeeey commented Oct 7, 2024

const unsigned* const __restrict

That's not standard c++.

@toxieainc
Copy link
Contributor Author

True, but pretty much all common c++ compilers accept it, we also use it in all commercial code i work on for a living (which covers pretty much all x86/arm/ppc platforms in use nowadays). In fact, most c++ compilers generate less efficient code without it.
But if you prefer, i can also remove it, of course.

@dukeeeey
Copy link
Collaborator

dukeeeey commented Oct 8, 2024

Supermodel ends up on all kinds of platforms you wouldn't expect, xbox etc. Would prefer to use standard functions. But the texture loading code is not a hot path. In such cases readability is more preferable.

@toxieainc
Copy link
Contributor Author

Removed again..

@dukeeeey dukeeeey merged commit c4d0269 into trzy:master Oct 10, 2024
@toxieainc toxieainc deleted the more_analysis_fixes branch October 10, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants