Skip to content

enforcing pickle to use copy of dict while serializing extra context of the notification #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enforcing pickle to use copy of dict while serializing extra context of the notification #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff1b5f
enforcing pickle to use copy of dict while serializing extra context …
hurturk Apr 15, 2014
1191a64
forcing pickle to generate same letter sequence
hurturk May 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion feedly/serializers/activity_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,15 @@ def dumps(self, activity):
activity.object_id, activity.target_id or 0]
extra_context = activity.extra_context.copy()
pickle_string = ''

# dictionaries are unsorted data structures
# however, using pickled dictionary as a key still differs by letter sequence
# this is a temporary solution works in our case
import operator
extra_context = dict(sorted(extra_context.iteritems(), key=operator.itemgetter(1)))

if extra_context:
pickle_string = pickle.dumps(activity.extra_context)
pickle_string = pickle.dumps(extra_context)
parts += [activity_time, pickle_string]
serialized_activity = ','.join(map(str, parts))
return serialized_activity
Expand Down