Skip to content

fix: update hole_diameter default value to 0.3mm in pcb_via #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rushabhcodes wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: update hole_diameter default value to 0.3mm in pcb_via #362

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c23d0f2
fix: update hole_diameter default value to 0.3mm in pcb_via
rushabhcodes Nov 26, 2025
88037d2
fix: make outer_diameter and hole_diameter optional in pcb_via
rushabhcodes Nov 26, 2025
1b35574
fix: make outer_diameter and hole_diameter required in pcb_via
rushabhcodes Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/pcb/pcb_via.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ export const pcb_via = z
subcircuit_connectivity_map_key: z.string().optional(),
x: distance,
y: distance,
outer_diameter: distance.default("0.6mm"),
hole_diameter: distance.default("0.25mm"),
outer_diameter: distance.default("0.6mm").optional(),
hole_diameter: distance.default("0.3mm").optional(),
/** @deprecated */
from_layer: layer_ref.optional(),
/** @deprecated */
Expand All @@ -40,8 +40,8 @@ export interface PcbVia {
subcircuit_connectivity_map_key?: string
x: Distance
y: Distance
outer_diameter: Distance
hole_diameter: Distance
outer_diameter?: Distance
hole_diameter?: Distance
/** @deprecated */
from_layer?: LayerRef
/** @deprecated */
Expand Down