Fix: Add is_covered_with_solder_mask to polygon smtpad#499
Open
yifan19860831-hub wants to merge 1 commit intotscircuit:mainfrom
Open
Fix: Add is_covered_with_solder_mask to polygon smtpad#499yifan19860831-hub wants to merge 1 commit intotscircuit:mainfrom
yifan19860831-hub wants to merge 1 commit intotscircuit:mainfrom
Conversation
- Add is_covered_with_solder_mask property to pcb_smtpad_polygon - Add soldermask_margin property to pcb_smtpad_polygon - Fixes tscircuit/tscircuit#786
Author
|
Hi @tscircuit/maintainers! 👋 This PR (#499) has been open for 2+ days without activity. Could you please take a look when you have a chance? Happy to make any needed changes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds is_covered_with_solder_mask and soldermask_margin properties to pcb_smtpad_polygon type.
Changes
Related Issue
Fixes tscircuit/tscircuit#786
Testing
/claim #786