fix: use LayerRef for via route point from_layer/to_layer#521
Merged
seveibar merged 1 commit intotscircuit:mainfrom Mar 18, 2026
Merged
fix: use LayerRef for via route point from_layer/to_layer#521seveibar merged 1 commit intotscircuit:mainfrom
seveibar merged 1 commit intotscircuit:mainfrom
Conversation
PcbTraceRoutePointVia.from_layer and .to_layer were typed as plain string while the wire variant already used LayerRef. This caused downstream consumers to need unsafe type assertions when passing via layers to functions expecting LayerRef.
seveibar
approved these changes
Mar 18, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PcbTraceRoutePointVia.from_layerand.to_layerfromz.string()tolayer_refin both the Zod schema and the TypeScript interfaceLayerReffor itslayerfield — this makes the via variant consistentas LayerReftype assertions in downstream consumers (e.g. dsn-converter)Test plan
npx tsc --noEmitpasses (no new type errors)bun testpasses (200/200, 1 pre-existing skip)