fix: add Load Example button and fix example file download (#11)#231
Open
colorbank wants to merge 1 commit into
Open
fix: add Load Example button and fix example file download (#11)#231colorbank wants to merge 1 commit into
colorbank wants to merge 1 commit into
Conversation
) - Add 'Load Example' button that fetches the example circuit JSON from the raw GitHub URL and loads it directly into the viewer - Change footer link from GitHub blob URL to raw GitHub URL with download attribute so the file actually downloads - Fixes tscircuit#11 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@colorbank is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Quick unblock request: this PR is ready from the code side, but the only failing status is Vercel authorization. Current status:
Could a tscircuit team member please authorize the Vercel deployment so the status check can proceed? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #11
The "example circuit json file" link pointed to the GitHub blob viewer URL (
/blob/main/assets/...) which:Solution
Two changes in
src/App.tsx:Added a "Load Example" button in the upload section — fetches the example JSON from the raw GitHub URL and loads it directly into the Circuit JSON Viewer with one click. No manual download/upload needed.
Fixed the footer download link — changed from GitHub blob URL to the raw GitHub URL with
download="usb-c-flashlight.json"attribute, so clicking it actually downloads the file.Testing
/claim #11