Skip to content

feat: add test for KiCad JST XH connector#2030

Open
techmannih wants to merge 2 commits intotscircuit:mainfrom
techmannih:ja
Open

feat: add test for KiCad JST XH connector#2030
techmannih wants to merge 2 commits intotscircuit:mainfrom
techmannih:ja

Conversation

@techmannih
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment Mar 10, 2026 8:07pm

Request Review

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@seveibar
Copy link
Contributor

Can you provide a screenshot of this footprint in kicad

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cant make external api requests in tests

@techmannih
Copy link
Member Author

@seveibar Seems like kicad-viewer not updated
Screenshot_2026-03-11_01-16-34

@seveibar
Copy link
Contributor

Open it in kicad

@techmannih
Copy link
Member Author

You cant make external api requests in tests

But we are using same for existing other test???? Do we need to remove them also?
https://github.com/tscircuit/core/blob/main/tests/features/kicad-usb-connector-footprint.test.tsx
https://github.com/tscircuit/core/blob/main/tests/features/kicad-jst-connector-footprint.test.tsx

@techmannih
Copy link
Member Author

@seveibar
Screenshot_2026-03-11_01-26-52

@techmannih techmannih requested a review from seveibar March 10, 2026 20:14
@techmannih techmannih changed the title feat: add test for KiCad JST XH connector footprint feat: add test for KiCad JST XH connector Mar 10, 2026
@seveibar
Copy link
Contributor

So your snapshot looks wrong

@github-actions
Copy link

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants