Refactor: implement upward directional bias for positive nets with type-safe packing logic#62
Open
AliReda95 wants to merge 3 commits intotscircuit:mainfrom
Open
Refactor: implement upward directional bias for positive nets with type-safe packing logic#62AliReda95 wants to merge 3 commits intotscircuit:mainfrom
AliReda95 wants to merge 3 commits intotscircuit:mainfrom
Conversation
Refactor comments for clarity and conciseness in network filtering logic.
Added upward bias for pins connected to positive voltage nets in the packing solver.
Added upward bias for partition-level pads connected to positive voltage nets and updated packing strategies.
|
@AliReda95 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the requested upward directional bias for positive voltage nets (VCC/V+/VDD) to optimize schematic layouts and reduce trace overlapping. It also includes critical bug fixes for the packing solver to ensure compatibility with existing test suites.
Key Changes:
Schematic Layout Optimization: Updated networkFiltering.ts to identify positive voltage nets and apply a vertical bias during the auto-layout process.
Solver Stability: Refactored PartitionPackingSolver.ts and SingleInnerPartitionPackingSolver.ts to resolve type conflicts and restore original pin pad dimensions (0.01), ensuring the packing algorithm remains stable and passes all Bun tests.
Type Safety: Corrected the availableRotationDegrees type handling from as const back to strict array definitions to maintain compatibility with the PackInput interface.
Code Quality: Applied biome formatting rules across all modified files to ensure CI/CD compliance.
Verification:
The changes have been cross-referenced with the core logic to prevent regressions in component packing while achieving a cleaner, more professional schematic orientation for power rails.