Skip to content

Refactor: implement upward directional bias for positive nets with type-safe packing logic#62

Open
AliReda95 wants to merge 3 commits intotscircuit:mainfrom
AliReda95:main
Open

Refactor: implement upward directional bias for positive nets with type-safe packing logic#62
AliReda95 wants to merge 3 commits intotscircuit:mainfrom
AliReda95:main

Conversation

@AliReda95
Copy link
Copy Markdown

Overview
This PR implements the requested upward directional bias for positive voltage nets (VCC/V+/VDD) to optimize schematic layouts and reduce trace overlapping. It also includes critical bug fixes for the packing solver to ensure compatibility with existing test suites.
​Key Changes:
​Schematic Layout Optimization: Updated networkFiltering.ts to identify positive voltage nets and apply a vertical bias during the auto-layout process.
​Solver Stability: Refactored PartitionPackingSolver.ts and SingleInnerPartitionPackingSolver.ts to resolve type conflicts and restore original pin pad dimensions (0.01), ensuring the packing algorithm remains stable and passes all Bun tests.
​Type Safety: Corrected the availableRotationDegrees type handling from as const back to strict array definitions to maintain compatibility with the PackInput interface.
​Code Quality: Applied biome formatting rules across all modified files to ensure CI/CD compliance.
​Verification:
The changes have been cross-referenced with the core logic to prevent regressions in component packing while achieving a cleaner, more professional schematic orientation for power rails.

Refactor comments for clarity and conciseness in network filtering logic.
Added upward bias for pins connected to positive voltage nets in the packing solver.
Added upward bias for partition-level pads connected to positive voltage nets and updated packing strategies.
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 12, 2026

@AliReda95 is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant