fix: remove extra trace for net-label-only repro61#123
fix: remove extra trace for net-label-only repro61#123CuboYe wants to merge 1 commit intotscircuit:mainfrom
Conversation
Filter MspConnectionPairSolver queue to skip nets connected solely via netConnections (net labels). These nets should receive only net label placements, not MSP pairs / traces. Adds SchematicTracePipelineSolver_repro61 test verifying no traces are produced for VCC/GND net-label-only connections. Updates MspConnectionPairSolver_repro1 expectation and SVG snapshots to reflect correct behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Happy to address any feedback — let me know if there are any changes needed. Thanks! |
|
@maintainers quick follow-up from contributor side: happy to adjust this PR if there are specific changes needed for merge. Could you share required edits or next-step guidance? |
|
Friendly follow-up on this stale PR (>48h): still ready on my side, with green checks and reproducible behavior. If you want any tweak before merge I can turn it around quickly. 🙏 |
|
Quick stale-lane follow-up: this PR is still ready to merge on my side. If you want any changes before merge, I can push an update immediately. |
|
Maintainer ping for stale lane triage: this PR is still merge-ready on contributor side (scoped fix, green checks, reproducible case). If you want any adjustment before merge, I can push immediately. |
|
Maintainer stale-lane ping: this PR is still merge-ready on contributor side (scoped fix, green checks, reproducible case). If there’s any required change before merge, I can push it immediately. |
|
Maintainer stale-lane ping (>48h): this PR remains merge-ready on contributor side (scoped fix + green checks). If there’s any merge blocker, I can patch it immediately. |
|
Maintainer stale-lane ping (>48h): this PR remains merge-ready on contributor side (scoped fix + green checks + reproducible case). To reduce review friction I can also push a quick test-case/docs tweak immediately if preferred—just point me at desired direction. |
2 participants
Fixes #79
/claim #79
What changed
Validation