fix: remove duplicate trace segments in same-net routing (issue #78)#126
Open
Nicolas-Rozas wants to merge 1 commit intotscircuit:mainfrom
Open
fix: remove duplicate trace segments in same-net routing (issue #78)#126Nicolas-Rozas wants to merge 1 commit intotscircuit:mainfrom
Nicolas-Rozas wants to merge 1 commit intotscircuit:mainfrom
Conversation
…sue tscircuit#78) When the MSP solver independently routes multiple pin pairs in the same net, two traces can share a physical segment near shared pins, producing "extra trace lines" in the schematic output. Changes: - Add `removeNetSegmentDuplicates` utility that detects cross-trace duplicate segments within the same net and trims redundant endpoint segments from later traces (the net remains visually connected through the first trace) - Apply deduplication as input preprocessing in `TraceCleanupSolver` so all subsequent cleanup steps (turn minimization, Z-shape balancing) work on clean data from the start - Add `removeDuplicateConsecutivePoints` in `simplifyPath` to also handle zero-length within-trace segments from UntangleTraceSubsolver path concatenation - Update snapshots for examples 02, 13, 15 which now show cleaner output - Add test suite covering both fix types and a full-pipeline regression test
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #78
Root Cause
SchematicTraceLinesSolversolves each MSP connection pair independently. When two pairs in the same net share a pin, both route through the same physical segment near that shared endpoint — producing "extra trace lines" in the rendered schematic.Fix
1. Cross-trace deduplication —
removeNetSegmentDuplicates.ts(new)Groups traces by net, finds segments that appear in more than one trace, and trims those redundant endpoint segments from later traces. The net remains visually connected through the first trace that claimed the segment.
Applied as input preprocessing in the
TraceCleanupSolverconstructor so all downstream cleanup steps (turn minimization, Z-shape balancing) operate on clean data from the start.2. Within-trace deduplication —
simplifyPath.tsAdded
removeDuplicateConsecutivePointscalled at the top ofsimplifyPath. This removes zero-length segments thatUntangleTraceSubsolvercan introduce at path-concatenation junctions.Tests
tests/solvers/TraceCleanupSolver/removeNetSegmentDuplicates.test.tsOverlapAvoidanceStepSolverfixture asserting zero duplicate segments