feat: merge collinear same-net trace lines on same X or Y axis#128
Open
noorbalaum wants to merge 1 commit intotscircuit:mainfrom
Open
feat: merge collinear same-net trace lines on same X or Y axis#128noorbalaum wants to merge 1 commit intotscircuit:mainfrom
noorbalaum wants to merge 1 commit intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #34
Fixes #34
Trace lines on the same net that land on the same X or Y axis were staying as separate segments instead of being one clean line. This adds a merge step to fix that.
What I did
mergeSameNetTraceLinesinmerge-same-net-trace-lines.tsSchematicTraceLinesSolverfinishesTested
bun test tests/functions/merge-same-net-trace-lines.test.ts✅tsc --noEmit✅biome checkon changed files ✅