Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sorting bug pedigrees #2224

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

GertjanBisschop
Copy link
Member

@GertjanBisschop GertjanBisschop commented Dec 5, 2023

In some cases the edge table that gets produced when recording additional nodes will end up not being correctly sorted. The added test replicates this bug. Test should probably part of the C codebase, but have not been able to produce a smaller example with the same issue.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #2224 (a191cb2) into main (873c2cc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2224   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          20       20           
  Lines       11333    11334    +1     
  Branches     2302     2302           
=======================================
+ Hits        10372    10373    +1     
  Misses        523      523           
  Partials      438      438           
Flag Coverage Δ
C 91.52% <100.00%> (+<0.01%) ⬆️
python 98.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/msprime.c 86.12% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873c2cc...a191cb2. Read the comment docs.

@mergify mergify bot merged commit c6e9573 into tskit-dev:main Dec 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants