Skip to content

fix browser page width on load #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix browser page width on load #1465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion html/src/components/terminal/xterm/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export class Xterm {
private reconnect = true;
private doReconnect = true;
private closeOnDisconnect = false;
private preferencesApplied = false;

private writeFunc = (data: ArrayBuffer) => this.writeData(new Uint8Array(data));

Expand Down Expand Up @@ -166,7 +167,6 @@ export class Xterm {
terminal.loadAddon(webLinksAddon);

terminal.open(parent);
fitAddon.fit();
}

@bind
Expand Down Expand Up @@ -466,6 +466,14 @@ export class Xterm {
break;
}
}

if (!this.preferencesApplied) {
Copy link
Owner

@tsl0922 tsl0922 Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requestAnimationFrame is one-shot call, can we remove this check?

this.preferencesApplied = true;

requestAnimationFrame(() => {
fitAddon.fit();
});
}
}

@bind
Expand Down