feat(viewer): make intent-trace-flow animation loop continuously - #339
Open
sanpatricky wants to merge 1 commit into
Open
feat(viewer): make intent-trace-flow animation loop continuously#339sanpatricky wants to merge 1 commit into
sanpatricky wants to merge 1 commit into
Conversation
Change animation-iteration-count from 1 to infinite so the flow animation keeps running while the trace is active, rather than playing once and fading out. Simplify keyframes to maintain constant opacity (0.94) throughout the loop for smooth continuous flow visualization. Existing motion guards (Still mode, reduced-motion, document-hidden, export) are preserved and continue to disable the animation. Closes tt-a1i#337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and value
When
meta.animation: "trace"is enabled and the viewer is in Live mode, hovering over a node triggers the intent-trace-flow animation on connected edges. The animation plays once (1.15s) with a fade-in/fade-out (opacity 0.28 → 0.94 → 0), then disappears. Users expect continuous flow while hovering — the single play requires repeatedly moving the mouse to re-trigger, making it hard to observe data flow direction and connectivity.Fixes #337
Scope
archify/assets/template.htmlline 4417:animation-iteration-countfrom1 bothtoinfinite— loops continuously while trace is active.archify/assets/template.htmllines 4747–4751: simplified@keyframes archify-intent-trace-flowto maintain constantopacity: 0.94throughout (removed fade-in from 0.28 and fade-out to 0).data-motion="still",data-document-hidden="true",data-motion-capable, reduced-motion preference, and export states still setanimation: none !important.story-trail-flow,route-probe-flow,route-journey-flow,semantic-lens-flow) are untouched.Stability impact
meta.animation: "trace"is explicitly authored. Still mode (default), reduced motion, export, and print are unaffected.deliverwill include the new animation behavior.Tests run
Not applicable for CSS animation behavior — no existing test exercises animation iteration count. Manual verification: opened a workflow diagram with
animation: "trace"in Chrome, switched to Live mode, hovered over nodes, confirmed continuous flow animation that stops correctly when switching to Still mode.Visual evidence
Not applicable for a looping CSS animation change — screenshots cannot convey animation continuity. Reproducible steps:
"animation": "trace"in metadeliverand open the HTMLGenerated artifacts
Template change affects all future
deliveroutputs. No existing Gallery, guide, or README artifacts need regeneration — they are delivered artifacts frozen at their build time.The
archify.zippackage would need rebuilding if this change is accepted, sinceassets/template.htmlis a packaged source.Checklist
npm testinarchify/. — CSS-only change; no test covers animation iteration countarchify.ziprebuild needed if accepted