docs: align contribution and bot review with change impact - #346
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
📝 SummarySummaryUpdates repository review policy and CodeRabbit configuration to align review scope and evidence with change impact.
Compatibility impactChanges are limited to repository documentation, the PR template, and ValidationThe author reports focused tests, whitespace checks, CodeRabbit schema validation, guideline-path checks, and Markdown link resolution. These checks were not independently observed here. No browser or perceptual acceptance is claimed. WalkthroughChangesReview process and contribution guidance
Estimated code review effort: 3 (Moderate) | ~20 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem and value
Reviewers currently rediscover impact and acceptance boundaries, while repository-only prose and focused test corrections inherit a local full-suite requirement. Bot checks can also duplicate requests: on PR #351, scope assessment requested archive evidence while Validation Evidence had already inspected that archive.
Bound review by changed behavior and callers, settle scope before expensive integration work, and re-review new changes plus unresolved findings. CONTRIBUTING.md owns author requirements; REVIEWING.md owns reviewer procedure; the shorter template collects decision-relevant evidence. Align CodeRabbit with these same rules. Refs #344.
Stability impact
Tests run
Comparison base:
06bd6fea5752bc06b8170a1f09085c798df5aa13. Candidate:a3bdf15(full SHA in PR head).On the candidate content with Node 22.23.2:
node --test archify/test/community-proof-intake.test.mjs: 3 passed, 0 failed, 0 skipped.git diff --check origin/main: clean.Reproduce schema validation (Python environment with PyYAML/jsonschema):
No local renderer suite: the four changed files do not affect renderer, package or site inputs. Current-head remote checks and bot review must be read separately; older CI is not a current pass.
Historical procedure pilots at the previous policy candidate
e9a6fe67545a0433c72c49facdfaf851ed339292(reused design evidence, not new-head executions):ab4908b1618002f3c1372303d1106f0c56f4b4ca: contract/shared change needs a scope decision on automatic v2 lane sizing versus public lane.height semantics before another full implementation review. No new browser/full-suite claim.16ef0cd3e6c4031be906f89de1d92e0e46c069b7: focused test-only change fits targeted verification; Windows base-fail/head-pass remained author-reported and remote CI required action. No merge acceptance inferred.Current policy review scenarios: repository prose needs content/link checks; shared geometry needs caller tracing and comparable relevant artifacts; fork CI awaiting approval needs maintainer action; reused archive evidence should not be requested again solely because a binary diff is excluded. These are manual policy-consistency checks, not proof of future LLM behavior or measured review-time savings. Observe the first 5–10 reviewed PRs before expanding enforcement.
Visual evidence
Not applicable: repository review policy only; no diagram, Viewer or public-page appearance/interaction changes.
Generated artifacts
None. These root/GitHub policy files are outside packaged archify/ and generated site inputs; ZIP and Gallery sources are unchanged.