fixed the actual root of #32 - #34
Open
hatsumatsu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out #32 was caused by having a capability check in the function that registered the field, so the field is not registered for non-admin users:
acf-vimeo-pro-data/admin-settings.php
Line 12 in 6ed6769
I think it's not necessary there and could rather be tackled in the
capabilitesfield ofacf_add_options_sub_page().Got the hint in
https://support.advancedcustomfields.com/forums/topic/get_field-field-option-return-null-for-non-admin-users/#post-150078
Works fine in my tests.