Repository navigation
Stokes refactor - #137
Merged
Merged
Stokes refactor#137
Conversation
… and dust for one-fluid dumps
Contributor
Author
|
Made a bare bones unit test based on the image in the PR description |
Docs update
Returned sigma might have a different length to bins
# Conflicts: # sarracen/disc/surface_density.py
modified surface_density function to compute surface densities of gas…
Bug fix in calc_one_fluid_quantities()
Update from np.trapz to np.trapezoid
# Conflicts: # sarracen/disc/surface_density.py
Modernize type hints to 3.10 style
# Conflicts: # sarracen/sarracen_dataframe.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing on differing number of dust and gas particles
Same dataset with one more dust particle. Dust particle 4 is a neighbour of gas particle 2 but gas particle 2 is not a neighbour of dust particle 4