Repository navigation
Returned sigma might have a different length to bins - #147
Merged
Merged
Conversation
…are zero particles in a bin (otherwise it returns an array of a different length)
ttricco
approved these changes
Jul 27, 2026
ttricco
left a comment
ttricco
left a comment
Owner
There was a problem hiding this comment.
This occurs with pandas versions 3.0+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at a particular phantom file and found that the sigma returned from surface_density could have a different length to the number of bins I requested. It seems to occur when some of the bins have zero particles and that entry is silently dropped. I don't know if anyone else has had this problem but it made it difficult to plot because sigma and bins were not indexed in the same way and had differing lengths. Can provide file for testing if needed.