-
Notifications
You must be signed in to change notification settings - Fork 110
Add tables aws_s3tables_namespace
, aws_s3tables_table
and aws_s3tables_table_bucket
#2498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aws_s3tables_namespace
, aws_s3tables_table
and aws_s3tables_table_bucket
…s and remove extra like break in the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for AWS S3 Tables by introducing three new Steampipe tables (aws_s3tables_table_bucket
, aws_s3tables_namespace
, and aws_s3tables_table
) along with documentation, SDK client wiring, and region matrix logic.
- Added the S3Tables Go SDK dependency and client factory
- Implemented Steampipe table definitions for table buckets, namespaces, and tables (list/get/hydrate)
- Added docs for the three new tables and registered them in the plugin
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
go.mod | Added github.com/aws/aws-sdk-go-v2/service/s3tables |
docs/tables/aws_s3tables_table_bucket.md | Documentation for the aws_s3tables_table_bucket table |
docs/tables/aws_s3tables_table.md | Documentation for the aws_s3tables_table table |
docs/tables/aws_s3tables_namespace.md | Documentation for the aws_s3tables_namespace table |
aws/service.go | Introduced S3TablesClient to create the S3 Tables client |
aws/multi_region.go | Added S3TablesRegionsMatrix for service region support |
aws/plugin.go | Registered the three new tables in the plugin |
aws/table_aws_s3tables_table_bucket.go | Table definition and list/get logic for table buckets |
aws/table_aws_s3tables_namespace.go | Table definition and list/get logic for namespaces |
aws/table_aws_s3tables_table.go | Table definition and list/get logic for tables |
Comments suppressed due to low confidence (1)
docs/tables/aws_s3tables_table.md:2
- The title contains a duplicated word 'Tables'. Consider changing it to 'Query AWS S3 Tables using SQL' to avoid redundancy.
title: "Steampipe Table: aws_s3tables_table - Query AWS S3 Tables Tables using SQL"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthaI please take a look at the review comments. Thanks!!
aws/multi_region.go
Outdated
|
||
commonColumnData, err := getCommonColumns(ctx, d, nil) | ||
if err != nil { | ||
plugin.Logger(ctx).Error("S3TablesRegionsMatrix", "connection_name", d.Connection.Name, "unable to get partition name", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the error message correct? In the above function we are trying to get the common columns data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to plugin.Logger(ctx).Error("S3TablesRegionsMatrix", "getCommonColumns", "unable to get common column info", err)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthaI please take a look at the minor review comments
Integration test logs
Logs
Example query results
Results