-
Notifications
You must be signed in to change notification settings - Fork 1
Renamed the audit_log_api source to logging_log_entry and implement the Retry mechanism #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesThis PR migrates the GCP logging log entry source from the legacy Key Changes:1. Client Migration
2. Retry Mechanism Implementation
3. Data Mapping Updates
4. Configuration Improvements
5. Documentation Updates
Benefits:
Breaking Changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the audit_log_api
source to logging_log_entry
and implements comprehensive retry mechanisms for improved reliability. The change modernizes the GCP logging integration by migrating from the logadmin client to the GAPIC (Google API Go Client) logging client with configurable retry capabilities.
Key changes include:
- Complete replacement of the
audit_log_api
source with a newlogging_log_entry
source featuring configurable retry mechanisms - Migration from
cloud.google.com/go/logging
tocloud.google.com/go/logging/apiv2/loggingpb
for better API support - Introduction of a flexible log type filter mapping system for table-specific log filtering
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
tables/audit_log/audit_log_table.go |
Updates source reference and adds table-specific options for log type filtering |
tables/audit_log/audit_log_mapper.go |
Migrates from logadmin to GAPIC client types with protobuf message handling |
sources/logging_log_entry/logging_log_type_filter_map.go |
New file defining table-to-log-type mappings for flexible filtering |
sources/logging_log_entry/logging_log_entry_source_config.go |
New configuration structure with table-specific validation |
sources/logging_log_entry/logging_log_entry_source.go |
New source implementation with GAPIC client and retry mechanisms |
config/gcp_connection.go |
Adds configurable retry parameters for GAPIC clients |
Various documentation files | Updates documentation to reflect the source rename and new capabilities |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@ParthaI I rebased my local PR branch with this PR and did a little testing. Here's what I've seen:
So overall, looking pretty good. I presume the use pattern will be just setting up different partitions for the other log types (requests, etc) and collecting them separately? |
Hello @recharge-jmog, Thank you for testing the changes and sharing your feedback — it's much appreciated!
Yes, exactly. Each log type (e.g., request logs, etc.) will be handled via its own table and partition. In the original PR, I had reverted the changes related to the Thanks again! |
If I understand correctly then, once this PR is merged I should open a new PR (or rebase and revise my previous PR) to implement the requests table separately? |
Yes, correct @recharge-jmog! |
Example query results
Results