Implement Pause and Resume for RowSource #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update StatusFromProto to accept proto.Event Add ChunkWrittenFromProto, CompleteFromProto, StartedFromProto Update EventFromProto to handle all events - so we can also use from CLI
instead of reopening connection, forceMemoryRelease - flush all but 64Mb simplify worker memory calc - do not leave allocation for CLI just divide mem byu num workers
Add PausableObservable interface which stops even publishing when paused, adds a BlockWhilePaused function RowSource and CollectorImpl are now PausableObservables RowEnrichmentCollector.writeChunk and ArtifactSourceImpl.OnArtifactDiscovered call BlockWhilePaused CollectorImpl.onChunk calls checkJsonlSize which checks the size of the json destination folder and pause the source if it is too large
Remove logging
Add hysteresis to json size polling - do not unpause until < 75% max json size Add EnsureArtifactPath Rename req.MaxJsonlSizeMb to MaxTempCacheSizeMb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.