Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete recipe/feature/zm #263

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

Delete recipe/feature/zm #263

wants to merge 59 commits into from

Conversation

zenmcmillan
Copy link

Description

  • Save Button and close button styled

Changes Made

  • classes and ids renamed to follow Turing styling guide

  • save button will turn green when clicked

  • I have performed a self-review of my code

  • If it is a core feature, I have added thorough tests.

zenmcmillan and others added 30 commits August 26, 2023 17:54
@zenmcmillan
Add navigation bar to page
02d43bc
@zenmcmillan
Create CSS file in dist directory
ad72014
@zenmcmillan
Style the header and navigation bar
bd38127
@zenmcmillan
Style hover
872b3ab
@zenmcmillan
Added a few images and styled them
43d89b5
@zenmcmillan
Move the CSS code to the proper directory
238c129
@wlavery22
Merge pull request #1 from alfonsojack/page-layout/feature/zm
191f811 
Page layout/feature/zm
@alfonsojack
Add testing environment
75c4902
@alfonsojack
Set up imports/exports for testing environment
9d94f1f
@wlavery22
Merge pull request #2 from alfonsojack/testing-environment/feature/JA
1b7f41c 
Testing environment/feature/ja
@alfonsojack
Create 3 untested functions to filter recipes by tag, name, and ingre…
0c364fa 
…dient names
@alfonsojack
Add successful testing for findRecipeByTag function
3f625aa
@alfonsojack
Add successful testing for findRecipeByName function
6b8a4d6
@alfonsojack
Add successful testing for findRecipeIngredients function
c6d331d
@zenmcmillan
Merge pull request #3 from alfonsojack/filter-recipe-lists/feature/JA
79652c6 
Filter recipe lists/feature/ja
@zenmcmillan
Add calculateCost function to testData file
4129090
@zenmcmillan
Add function to testing files to get a recipe by id
f0a5662
@zenmcmillan
Make specificRecipe function pass test
fd90b0e
@zenmcmillan
CalculateCost function is now passing
27fbf31
@wlavery22
Merge pull request #4 from alfonsojack/recipe-tests/test/zm
f5dc4fe 
Recipe tests/test/zm
@wlavery22
Add final working findDirections function with passing test
4592bbb
@wlavery22
Add tested findDirections function
8bb2eb6
@alfonsojack
Fix importing data to test file and repass test
b9793fe
@zenmcmillan
Merge pull request #5 from alfonsojack/import-sample-data/fix/JA
8641dbd 
Fix importing data to test file and repass test
@zenmcmillan
Create function to show all recipes and their names when the main pag…
887b98c 
…e in loaded
@alfonsojack
Merge pull request #6 from alfonsojack/show-recipes/dom-manipulation/zm
2dbb8ec 
Create function to show all recipes and their names when the main pag…
@zenmcmillan
Fix Bug: Render recipes and names to the page on load
e6fadd8
@wlavery22
Merge pull request #7 from alfonsojack/dom-manipulation-bug-fix
c521112 
Fix Bug: Render recipes and names to the page on load
@alfonsojack
Add functionality to filter recipe by tag when tags are clicked
75f494d
@wlavery22
Merge pull request #8 from alfonsojack/filter-recipe-on-DOM/feature/JA
ecde65e 
Add functionality to filter recipe by tag when tags are clicked
wlavery22 and others added 29 commits August 31, 2023 23:28
@wlavery22
Add display recipes function
518151d
@alfonsojack
Merge pull request #9 from alfonsojack/recipe-search/feature/DL
a2888e4 
Add display recipes function
@alfonsojack
Add all recipes button
b7532ea
@alfonsojack
Clean up JS files and fix styling on All Recipes Button
ca6f673
@wlavery22
Merge pull request #10 from alfonsojack/all-recipes-button/feature/JA
474e8ca 
All recipes button/feature/ja
@alfonsojack
Add event listeners to recipeCards that trigger styling changes and r…
7870b9e 
…eturn the specific recipe object on click
@alfonsojack
Add a function to open and populate a pop up with recipe details
b0772e2
@alfonsojack
Add calculated cost in the pop up display and refactor calculateCost …
b813d48 
…function to match IDs of different data type
@zenmcmillan
Merge pull request #11 from alfonsojack/view-recipe-button/feature/JA
9674a44 
View recipe button/feature/ja
@zenmcmillan
Create the saved Recipes button
62563c6
@zenmcmillan
Apply styling to the Saved Recipes button
f17cf05
@wlavery22
Merge pull request #12 from alfonsojack/saved-Recipes-button/feauture/zm
5827674 
Saved recipes button/feauture/zm
@alfonsojack
Add and refactor styling to buttons, change recipe card elements from…
cd39d01 
… divs to buttons for semantic HTML
@alfonsojack
Refactor findRecipeById to return alternate error message
b293a00
@alfonsojack
Add function to generate recipeToCook keys in every user object
77a4840
@alfonsojack
Add functionality to select random user, save recipes, display saves,…
95b7be1 
… and filter saves by search and tag
@wlavery22
Merge pull request #13 from alfonsojack/save-recipeToCook/feature/JA
b43a829 
Save recipe to cook/feature/ja
@zenmcmillan
Start the api call functions
65f80e9
@alfonsojack
Merge pull request #14 from alfonsojack/network-requests/feature/zm
a4125e9 
Start the api call functions
@alfonsojack
Pass API users through a function
e09b13d
@wlavery22
Merge pull request #15 from alfonsojack/pass-fetched-data/feature/JA
bf60c14 
Pass API users through a function
@alfonsojack
Fetch recipes API data and pass it through scripts functions
2129a44
@zenmcmillan
Merge pull request #16 from alfonsojack/fetch-and-pass-recipesAPI/fea…
5285772 
…ture/JA

Fetch recipes API data and pass it through scripts functions
@zenmcmillan
Change saved recipes link to use a class instead of an id
f0e3915
@zenmcmillan
npm
f015781
@zenmcmillan
Style save and close buttons
2b9b011
@zenmcmillan
Change id and class names of save recipes button
70723f4
@zenmcmillan
When the save button is clicked the text will change the saved and th…
214c34d 
…e color will change to green
@zenmcmillan
Fix pull request
ba51860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zenmcmillan @wlavery22 @alfonsojack