Update MVC lesson example, add MDN link to MVC #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfaerber
reviewed
Jul 18, 2023
lessons/module-3/mvc.md
Outdated
| } | ||
| } | ||
| function App() { | ||
| const [count, setCount] = useSate(0); |
There was a problem hiding this comment.
Just missing a 't' in state here :)
hfaerber
requested changes
Jul 19, 2023
There was a problem hiding this comment.
Thanks for working on this Scott! I made 2 comments on the code example.
Could you also edit the very end of the lesson please?
- In the Wrapping it up section, can you please remove "How does Redux play into this? Work on this for 10 minutes, then we’ll reconvene."
- In the References section, can you please stack the two links so its clear there are two?
lessons/module-3/mvc.md
Outdated
| @@ -63,35 +63,31 @@ for this pattern, you will find it all over the place. | |||
|  | |||
|
|
|||
| Take a look at [the docs on MDN](https://developer.mozilla.org/en-US/docs/Glossary/MVC) if you'd like to see it explained in another way. | |||
|
|
|||
| ### Ok, by why would I ever use it? | |||
|
|
|||
| You've already been using it! Let's consider a super simple example: | |||
|
|
|||
| ```js | |||
| import React, { Component } from 'react'; | |||
There was a problem hiding this comment.
We should be able to remove the {Component} import here
|
Thanks Heather! I made those changes and I'll merge it now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed issue #710
Summary of changes needed:
Changes Made:
Questions