Styling/applications index #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the existing styling of the job applications index Changes include: - color correct status labels - consistent sizing of status labels - fixes h1 styling and alignment [Ticket: X]
This commit:
- makes status colors perfectly accurate to the mock up.
- I had to guess for "code challenge" because it was not included in the mockup.
- makes the status elements reactive to screen size and adds truncation.
[Ticket: #84]
…yling/applications-index Pulling to update branch with current main.
…t the cypress tests to pass in circleCI
…yling/applications-index pulling/merging to get branch up to date
…yling/applications-index pulling down main to get branch up to date
|
It's finally clearing all cypress tests. That was a doozie. |
TDManning
approved these changes
Feb 18, 2025
|
When working on this branch, I tried to add a job application and the dashboard number updated, but the job application did not show on the job application page, so I could not check the syling changes you made. |
…yling/applications-index
I just pulled it down and verified, I was able to create a new company > new application, page redirected but the PR does show issues with the branch so that does need to be resolved prior to merge |
…yling/applications-index Updating branch with most current main.
Crosswolfv1
approved these changes
Feb 20, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refactors the styling of the Applications Index and Utility.
Motivation and Context
To make styling across the application consistent and in keeping with the provided mock ups.
https://github.com/orgs/turingschool/projects/15/views/1?pane=issue&itemId=2841138069&issue=turingschool%7Ctracker-crm-fe%7C84
Related Tickets
close sub issue #84 in ticket #70 (https://github.com/orgs/turingschool/projects/15/views/1?pane=issue&itemId=96291083&issue=turingschool%7Ctracker-crm-fe%7C70)
Screenshots:
Screenshot:
Mock Up:
Added Test?
Checklist: