Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor notifications #4883

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Refactor notifications #4883

merged 7 commits into from
Jan 22, 2025

Conversation

Lakoja
Copy link
Collaborator

@Lakoja Lakoja commented Jan 18, 2025 •
edited
Loading

Also fixes #4858.
But apart from that there should be no functional change.

Lakoja
Lakoja commented Jan 18, 2025
View reviewed changes
app/src/main/java/com/keylesspalace/tusky/MainActivity.kt Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/MainActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/TuskyApplication.kt
@@ -75,6 +75,7 @@ class TuskyApplication : Application(), Configuration.Provider {
NEW_INSTALL_SCHEMA_VERSION
)
if (oldVersion != SCHEMA_VERSION) {
// TODO SCHEMA_VERSION is outdated / not updated in code
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collateral find.

app/src/main/java/com/keylesspalace/tusky/usecase/LogoutUsecase.kt Show resolved Hide resolved
@Lakoja Lakoja requested a review from connyduck January 18, 2025 15:56
connyduck
connyduck requested changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@connyduck connyduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is a very good idea, thank you!

I have mostly Kotlin style complaints, and I think NotificationHelper can now be deleted?

app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt Outdated Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt Outdated Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt Outdated Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt Outdated Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt Outdated Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt Outdated Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt Outdated Show resolved Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationService.kt Outdated Show resolved Hide resolved
@Lakoja Lakoja force-pushed the refactor-notifications branch from 899df36 to 1919543 Compare January 19, 2025 08:30
@Lakoja Lakoja force-pushed the refactor-notifications branch from 1919543 to dc16b04 Compare January 19, 2025 11:04
@connyduck connyduck merged commit 3a3e056 into tuskyapp:develop Jan 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connyduck connyduck connyduck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications are always disabled on first application run
2 participants
@Lakoja @connyduck