fix trending tags for rtl languages #4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connyduck
commented
Jan 22, 2025
| @@ -41,7 +41,7 @@ class TrendingTagViewHolder( | |||
| binding.totalAccounts.text = formatNumber(totalAccounts, 1000) | |||
|
|
|||
| binding.currentUsage.text = numberFormat.format(tagViewData.usage.last()) | |||
| binding.currentAccounts.text = numberFormat.format(tagViewData.usage.last()) | |||
| binding.currentAccounts.text = numberFormat.format(tagViewData.accounts.last()) | |||
There was a problem hiding this comment.
Ooops we have been showing the wrong number all the time
connyduck
commented
Jan 22, 2025
| @@ -8,7 +8,6 @@ import kotlin.math.abs | |||
| import kotlin.math.ln | |||
| import kotlin.math.pow | |||
|
|
|||
| private val numberFormatter: NumberFormat = NumberFormat.getInstance() | |||
There was a problem hiding this comment.
The static NumberFormat is bad because it doesn't update when the locale changes.
Tak
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4887
And some other small improvements like better paddings and font sizes. Also the
status_infoinitem_statusnow looks nicer in rtl mode.