Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add live alert type selection #41201

Closed

Conversation

MohamadSalman11
Copy link
Contributor

@MohamadSalman11 MohamadSalman11 commented Feb 3, 2025

Description

Added a select to choose different alert types. When the "Show live alert" button is clicked, an alert is displayed with the selected type (e.g., success, danger, info, etc.).

Motivation & Context

Improves user experience by allowing easy selection of alert types, making the interface more interactive

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@MohamadSalman11 MohamadSalman11 requested a review from a team as a code owner February 3, 2025 12:29
@julien-deramond
Copy link
Member

Thanks for your contribution, @MohamadSalman11! However, we aim to keep the snippets/examples minimalist and focused solely on the specific functionality being demonstrated. Adding a select for different alert types introduces additional UI elements that go beyond the intended scope and makes the code more complex for readers to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants