Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows and PowerShell commands for creating project directories and files #41206

Conversation

MohamadSalman11
Copy link
Contributor

@MohamadSalman11 MohamadSalman11 commented Feb 5, 2025

Description

In the Bundler guide section, there were steps to create the necessary folders and files for macOS and Linux. It is also good to include commands for Windows users, as those using Windows can copy the commands and it will now work

Motivation & Context

To make it easier for Windows users to follow along and ensure consistency across all platforms

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond
Copy link
Member

julien-deramond commented Feb 6, 2025

Thanks for the suggestion! I see the value in making the guide more inclusive for Windows users. That said, adding these extra steps might complicate things, as some Windows users might already find the general commands work fine (especially those using Git Bash or WSL). I'd love to hear more feedback from other Windows users like @louismaximepiton or @XhmikosR to see if this would be helpful to a broader audience.

@XhmikosR
Copy link
Member

I agree, the current instructions are enough since the people that use the native Windows CMD shouldn't be a lot.

@XhmikosR XhmikosR closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants