Merged
Conversation
88cfc14 to
35a8ac7
Compare
Member
Author
|
IntersectMBO/cardano-ledger#5747 was approved, so this one is good to go as well |
qnikst
approved these changes
Apr 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the new gov/proposals/roots/v0 SCLS namespace, wiring it into the schema registry, conformance tests, and reference CDDL loading, while bumping the pinned CIP-0165 source revision used in CI/Nix.
Changes:
- Introduce
Cardano.SCLS.Namespace.GovProposalsRootsand registergov/proposals/roots/v0inCardano.SCLS.CDDL(KnownSpec, namespace list, key size). - Extend test utilities and reference CDDL mapping to include
gov/proposals/roots/v0. - Update the pinned
tweag/CIPsrevision in Nix + CI and relocategov_action_idintoCardano.SCLS.Commonfor reuse.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scls-cardano/testlib/Cardano/SCLS/Testlib.hs | Adds the new namespace to the conformance test runner. |
| scls-cardano/test/Reference.hs | Adds reference CDDL filename mapping for gov/proposals/roots/v0. |
| scls-cardano/scls-cardano.cabal | Registers the new namespace module in the library build. |
| scls-cardano/cddl-src/Cardano/SCLS/Namespace/GovProposalsRoots.hs | New schema module defining the namespace’s record_entry. |
| scls-cardano/cddl-src/Cardano/SCLS/Namespace/GovProposals.hs | Removes the local gov_action_id rule (now shared from Common). |
| scls-cardano/cddl-src/Cardano/SCLS/Common.hs | Adds shared gov_action_id rule. |
| scls-cardano/cddl-src/Cardano/SCLS/CDDL.hs | Registers KnownSpec + key size + knownNamespaces entry for the new namespace. |
| flake.nix | Bumps pinned tweag/CIPs revision. |
| flake.lock | Updates lock data for the bumped tweag/CIPs revision. |
| .github/workflows/haskell-ci.yml | Updates CI checkout ref for tweag/CIPs to match the new revision. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qnikst
reviewed
Apr 25, 2026
Member
|
Looks good to me, modulo Copilot and mine comment! Free to merge after checking those comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.