-
Notifications
You must be signed in to change notification settings - Fork 152
flake.lock: Update #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
1
commit into
main
Choose a base branch
from
update_flake_lock_action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
flake.lock: Update #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tweag-jupyterwith ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
91a7fcb to
bc600e1
Compare
98989e7 to
f751838
Compare
bf70c22 to
afe069b
Compare
870d922 to
88e6e8f
Compare
88e6e8f to
c9c3b3b
Compare
c9c3b3b to
fea18f8
Compare
fea18f8 to
eb2b8fe
Compare
eb2b8fe to
6a4fb5a
Compare
6863a46 to
f4f92cb
Compare
f4f92cb to
13f4b22
Compare
13f4b22 to
0a9b06d
Compare
f14d95a to
d0d5565
Compare
d0d5565 to
804057a
Compare
0722e26 to
9122057
Compare
9122057 to
f6a01c0
Compare
9dca610 to
b42f560
Compare
b42f560 to
36629a7
Compare
36629a7 to
4123e17
Compare
076db8a to
091913b
Compare
8442203 to
a388393
Compare
a388393 to
1a68a3c
Compare
1a68a3c to
af45c5f
Compare
af45c5f to
23bd9cb
Compare
jmmaloney4
added a commit
to jmmaloney4/jupyenv
that referenced
this pull request
Jul 19, 2025
## Problem
The rust kernel had an architectural inconsistency where it used two different
approaches to access nixpkgs packages:
1. **Module-level**: `requiredRuntimePackages = [config.nixpkgs.cargo ...]`
2. **Function-level**: `pkgs = import config.nixpkgs.path { ... }`
This caused evaluation failures when `config.nixpkgs.cargo` was undefined,
since users were only providing nixpkgs configuration (path + overlays)
rather than an instantiated package set.
## Root Cause Analysis
**Timeline of the inconsistency:**
- **Feb 9, 2023** (commit 9fc7d31): GuangTao Zhang introduced centralized
`config.nixpkgs` system. Rust kernel correctly used `config.nixpkgs.*`
- **Mar 16, 2023** (commit 0fea293): Dan Baker's "refactor/turn kernels into
modules" **accidentally combined two patterns**:
- Preserved module-level `config.nixpkgs.cargo` (correct for that system)
- Added function-level custom nixpkgs import (newer, more flexible approach)
- **July 19, 2025**: Recent improvements (commits 55655e3, 4d5f37c, e19f799)
enhanced flexibility but **inconsistency remained unfixed**
**Why it persisted:** The inconsistency was masked because module-level
`requiredRuntimePackages` usually overrode function-level defaults. Only
surfaced when users customized the kernel configuration.
## Solution
Updated `requiredRuntimePackages` to use the same `pkgs` instance that's
created with custom overlays, making the rust kernel architecturally
consistent:
```nix
# Before: Mixed approaches
requiredRuntimePackages = [config.nixpkgs.cargo ...]; # Uses config.nixpkgs
pkgs = import config.nixpkgs.path { overlays = ...; }; # Creates custom pkgs
# After: Consistent approach
pkgs = import config.nixpkgs.path { overlays = ...; }; # Create pkgs first
requiredRuntimePackages = [pkgs.cargo ...]; # Use same pkgs
```
This aligns the rust kernel with its own architectural pattern and eliminates
the dependency on `config.nixpkgs` being a package set.
## Testing
Verified the fix resolves evaluation errors in downstream projects that
configure rust kernels with custom nixpkgs paths and overlays.
Fixes tweag#564
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
23bd9cb to
cbaf0e0
Compare
cbaf0e0 to
a79efba
Compare
a0fd1a5 to
16dac7b
Compare
5f75f14 to
1f55a56
Compare
b114ba8 to
3033428
Compare
3033428 to
6d04ea8
Compare
6d04ea8 to
67ae08e
Compare
6b9f00b to
3a56123
Compare
3a56123 to
9a8e0b6
Compare
c9532e8 to
119a380
Compare
Flake lock file updates:
• Updated input 'flake-compat':
'github:edolstra/flake-compat/9ed2ac151eada2306ca8c418ebd97807bb08f6ac?narHash=sha256-HRJ/18p%2BWoXpWJkcdsk9St5ZiukCqSDgbOGFa8Okehg%3D' (2024-11-27)
→ 'github:edolstra/flake-compat/f387cd2afec9419c8ee37694406ca490c3f34ee5?narHash=sha256-XKUZz9zewJNUj46b4AJdiRZJAvSZ0Dqj2BNfXvFlJC4%3D' (2025-10-27)
• Updated input 'ihaskell':
'github:ihaskell/ihaskell/d896621edbf032a86fa85723911b0e75852402f2?narHash=sha256-vWd8sqQ2fBdlxqdpWAayS/PPeFf8BSVe1IRbqGFjwlI%3D' (2024-12-01)
→ 'github:ihaskell/ihaskell/9bbc5db18d1a3c5efb7522edb202f959074c831a?narHash=sha256-na5QfhNLm45LT9TZJO2rj6jAcL2jEiQdXJYT%2B0yCfrI%3D' (2025-08-18)
• Updated input 'ihaskell/hls':
'github:haskell/haskell-language-server/fea01358646a767980eb8645f7ef8878d83725fe?narHash=sha256-JTjkZOoDonda/EbIWXxPEr3hBVkVu2388XAxMWduKJQ%3D' (2024-11-25)
→ 'github:haskell/haskell-language-server/e3d38b0c4666681dca39901aa9d47b04422c82ff?narHash=sha256-FMCBKSS0pqKtPXqPrM95Gn9Mj7F9uPq4hLMMIXSlqaw%3D' (2025-08-11)
• Updated input 'ihaskell/hls/flake-compat':
'github:edolstra/flake-compat/0f9255e01c2351cc7d116c072cb317785dd33b33?narHash=sha256-kvjfFW7WAETZlt09AgDn1MrtKzP7t90Vf7vypd3OL1U%3D' (2023-10-04)
→ 'github:edolstra/flake-compat/9100a0f413b0c601e0533d1d94ffd501ce2e7885?narHash=sha256-CIVLLkVgvHYbgI2UpXvIIBJ12HWgX%2BfjA8Xf8PUmqCY%3D' (2025-05-12)
• Updated input 'ihaskell/hls/nixpkgs':
'github:NixOS/nixpkgs/e913ae340076bbb73d9f4d3d065c2bca7caafb16?narHash=sha256-Ds1QpobBX2yoUDx9ZruqVGJ/uQPgcXoYuobBguyKEh8%3D' (2024-06-11)
→ 'github:NixOS/nixpkgs/c742ae7908a82c9bf23ce27bfca92a00e9bcd541?narHash=sha256-E2640ouB7VxooUQdCiDRo/rVXnr1ykgF9A7HrwWZVSo%3D' (2025-05-28)
• Removed input 'ihaskell/nixpkgs24_11'
• Added input 'ihaskell/nixpkgs25_05':
'github:NixOS/nixpkgs/48f4c982de68d966421d2b6f1ddbeb6227cc5ceb?narHash=sha256-axUoWcm4cNQ36jOlnkD9D40LTfSQgk8ExfHSRm3rTtg%3D' (2025-08-17)
• Updated input 'nixpkgs':
'github:nixos/nixpkgs/31d66ae40417bb13765b0ad75dd200400e98de84?narHash=sha256-7NbtSLfZO0q7MXPl5hzA0sbVJt6pWxxtGWbaVUDDmjs%3D' (2024-12-01)
→ 'github:nixos/nixpkgs/a7fc11be66bdfb5cdde611ee5ce381c183da8386?narHash=sha256-QoJjGd4NstnyOG4mm4KXF%2BweBzA2AH/7gn1Pmpfcb0A%3D' (2025-10-31)
• Updated input 'nixpkgs-master':
'github:nixos/nixpkgs/88196cc0760e55b11c71f80df5f14bf3f836563c?narHash=sha256-bptm7zLlH9Q8Hxi0qBFhinYpKVkhrm0gGj9TARdT8z4%3D' (2024-12-02)
→ 'github:nixos/nixpkgs/ef7ef716552f30ba6894525ab6711af6e4e634fe?narHash=sha256-U4RjfZaVLVs8Fy5MZaslp62fbv/PVaPJjSQOdZjjw9A%3D' (2025-11-02)
• Updated input 'nixpkgs-stable':
'github:nixos/nixpkgs/62c435d93bf046a5396f3016472e8f7c8e2aed65?narHash=sha256-F7thesZPvAMSwjRu0K8uFshTk3ZZSNAsXTIFvXBT%2B34%3D' (2024-11-30)
→ 'github:nixos/nixpkgs/50ab793786d9de88ee30ec4e4c24fb4236fc2674?narHash=sha256-/bVBlRpECLVzjV19t5KMdMFWSwKLtb5RyXdjz3LJT%2Bg%3D' (2025-06-30)
• Updated input 'npmlock2nix':
'github:nix-community/npmlock2nix/9197bbf397d76059a76310523d45df10d2e4ca81?narHash=sha256-sJM82Sj8yfQYs9axEmGZ9Evzdv/kDcI9sddqJ45frrU%3D' (2023-01-11)
→ 'github:nix-community/npmlock2nix/4d9060afbaa5f57ee0b8ef11c7044ed287a7d302?narHash=sha256-qJc3ffjHVXUdZqytKcDK9XZ2b3BQ1RdYfZFuYgxbrn4%3D' (2025-09-17)
• Updated input 'opam-nix':
'github:tweag/opam-nix/ea8b9cb81fe94e1fc45c6376fcff15f17319c445?narHash=sha256-jj25fziYrES8Ix6HkfSiLzrN6MZjiwlHUxFSIuLRjgE%3D' (2024-11-26)
→ 'github:tweag/opam-nix/f59a622906dfe1139a5386008cf7dd8dac958afa?narHash=sha256-lUvmiyj7uCmDitSMW11J4OUC/MeKHrWG8gsy8naMMRM%3D' (2025-10-29)
• Updated input 'opam-nix/opam-overlays':
'github:dune-universe/opam-overlays/f2bec38beca4aea9e481f2fd3ee319c519124649?narHash=sha256-bwM18ydNT9fYq91xfn4gmS21q322NYrKwfq0ldG9GYw%3D' (2024-09-20)
→ 'github:dune-universe/opam-overlays/e031bb64e33bf93be963e9a38b28962e6e14381f?narHash=sha256-Z0PIW82fHJFvAv/JYpAffnp2DaOjLhsPutqyIrORZd0%3D' (2025-03-04)
• Updated input 'opam-nix/opam-repository':
'github:ocaml/opam-repository/3d52b66b04788999a23f22f0d59c2dfc831c4f32?narHash=sha256-kju4NWEQo4xTxnKeBIsmqnyxIcCg6sNZYJ1FmG/gCDw%3D' (2024-11-26)
→ 'github:ocaml/opam-repository/551314ad1550478ec6be39bb0eaadd2569190464?narHash=sha256-aUZWd0KOpEnioBwqlwRU40rUFAqT3RTlojXt2oI3omY%3D' (2025-10-09)
• Updated input 'opam-nix/opam2json':
'github:tweag/opam2json/819d291ea95e271b0e6027679de6abb4d4f7f680?narHash=sha256-5pXfbUfpVABtKbii6aaI2EdAZTjHJ2QntEf0QD2O5AM%3D' (2022-12-20)
→ 'github:tweag/opam2json/0ecd66fc2bfb25d910522c990dd36412259eac1f?narHash=sha256-%2BQVm%2BHOYikF3wUhqSIV8qJbE/feSG%2Bp48fgxIosbHS0%3D' (2025-06-09)
• Added input 'opam-nix/opam2json/systems':
'github:nix-systems/default/da67096a3b9bf56a91d16901293e51ba5b49a27e?narHash=sha256-Vy1rq5AaRuLzOxct8nz4T6wlgyUR7zLU309k9mBC768%3D' (2023-04-09)
• Updated input 'poetry2nix':
'github:nix-community/poetry2nix/f554d27c1544d9c56e5f1f8e2b8aff399803674e?narHash=sha256-F7N1mxH1VrkVNHR3JGNMRvp9%2B98KYO4b832KS8Gl2xI%3D' (2024-11-10)
→ 'github:nix-community/poetry2nix/ce2369db77f45688172384bbeb962bc6c2ea6f94?narHash=sha256-cX98bUuKuihOaRp8dNV1Mq7u6/CQZWTPth2IJPATBXc%3D' (2025-04-03)
• Updated input 'pre-commit-hooks':
'github:cachix/pre-commit-hooks.nix/3308484d1a443fc5bc92012435d79e80458fe43c?narHash=sha256-mnTbjpdqF0luOkou8ZFi2asa1N3AA2CchR/RqCNmsGE%3D' (2024-11-19)
→ 'github:cachix/pre-commit-hooks.nix/ca5b894d3e3e151ffc1db040b6ce4dcc75d31c37?narHash=sha256-BflA6U4AM1bzuRMR8QqzPXqh8sWVCNDzOdsxXEguJIc%3D' (2025-10-17)
• Removed input 'pre-commit-hooks/nixpkgs-stable'
• Updated input 'rust-overlay':
'github:oxalica/rust-overlay/e66c0d43abf5bdefb664c3583ca8994983c332ae?narHash=sha256-aJmAIjZfWfPSWSExwrYBLRgXVvgF5LP1vaeUGOOIQ98%3D' (2024-12-02)
→ 'github:oxalica/rust-overlay/63d22578600f70d293aede6bc737efef60ebd97f?narHash=sha256-Zo3LQQDz%2B64EQ9zor/WmeNTFLoZkjmhp0UY3G0D3seE%3D' (2025-11-01)
119a380 to
c6b2d82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by the update-flake-lock GitHub Action.
Running GitHub Actions on this PR
GitHub Actions will not run workflows on pull requests which are opened by a GitHub Action.
To run GitHub Actions workflows on this PR, run: