Skip to content

chore: migrate to target_compatible_with #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

chore: migrate to target_compatible_with #2106

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c42f98d
chore: migrate to target_compatible_with
cgrindel Jan 8, 2024
4782747
Try typing the correct label.
cgrindel Jan 8, 2024
0f2ba85
Set exec_compatible_with.
cgrindel Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion rules_haskell_tests/tests/asterius/asterius_tests_utils.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
load("@bazel_skylib//lib:selects.bzl", "selects")
load(
"@rules_haskell//haskell/asterius:defs.bzl",
"ahc_dist",
Expand All @@ -6,7 +7,12 @@ load(
"asterius_webpack",
)

tags = ["dont_test_on_windows", "dont_test_on_darwin", "skip_profiling", "dont_test_on_bazel_lt_4"]
tags = ["dont_test_on_windows", "skip_profiling", "dont_test_on_bazel_lt_4"]

target_compatible_with = selects.with_or({
("@platforms//os:macos"): ["@platforms//:incompatible"],
"//conditions:default": [],
})

def asterius_test_macro(
dep_label,
Expand All @@ -22,6 +28,8 @@ def asterius_test_macro(
entry_point = entry_point,
testonly = True,
tags = tags,
target_compatible_with = target_compatible_with,
exec_compatible_with = target_compatible_with,
)

asterius_test(
Expand All @@ -30,6 +38,8 @@ def asterius_test_macro(
entry_point = entry_point,
testonly = True,
tags = tags,
target_compatible_with = target_compatible_with,
exec_compatible_with = target_compatible_with,
)

asterius_binary(
Expand All @@ -38,6 +48,8 @@ def asterius_test_macro(
entry_point = entry_point,
testonly = True,
tags = tags,
target_compatible_with = target_compatible_with,
exec_compatible_with = target_compatible_with,
)

# TODO the following `asterius_binary_from_genrule` rule is meant to test
Expand All @@ -51,6 +63,8 @@ def asterius_test_macro(
tools = [":asterius_binary" + suffix],
testonly = True,
tags = tags + ["manual"],
target_compatible_with = target_compatible_with,
exec_compatible_with = target_compatible_with,
)

asterius_webpack(
Expand All @@ -59,4 +73,6 @@ def asterius_test_macro(
entry_point = entry_point,
testonly = True,
tags = tags,
target_compatible_with = target_compatible_with,
exec_compatible_with = target_compatible_with,
)