Skip to content

Conversation

ilya-bobyr
Copy link
Contributor

While the "List of cabal flags" implies that +flag and -flag syntax can be used, it is somewhat subtle and requires knowledge of cabal flags syntax. Documenting it directly here would not hurt.

While the "List of cabal flags" implies that `+flag` and `-flag` syntax
can be used, it is somewhat subtle and requires knowledge of cabal flags
syntax.  Documenting it directly here would not hurt.
@ilya-bobyr ilya-bobyr requested a review from avdv as a code owner October 1, 2025 22:54
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@avdv avdv added the merge-queue merge on green CI label Oct 2, 2025
@ilya-bobyr
Copy link
Contributor Author

Failures seems to be related to missing mingw dependencies in Windows builds:
https://github.com/tweag/rules_haskell/actions/runs/18177924495/job/51822246615?pr=2344

It is interesting that the same job succeeded for the master branch: https://github.com/tweag/rules_haskell/actions/runs/18191121234/job/51786238650

At the same time, my trivial change to the doc-string should not have any impact on the presence or absence of build dependencies.
Though, maybe, somehow, I'm looking at the wrong error, not sure.

@avdv
Copy link
Member

avdv commented Oct 7, 2025

Failures seems to be related to missing mingw dependencies in Windows builds: tweag/rules_haskell/actions/runs/18177924495/job/51822246615?pr=2344

It is interesting that the same job succeeded for the master branch: tweag/rules_haskell/actions/runs/18191121234/job/51786238650

At the same time, my trivial change to the doc-string should not have any impact on the presence or absence of build dependencies. Though, maybe, somehow, I'm looking at the wrong error, not sure.

The error seems to be related to the remote cache. Looking at the build (https://app.buildbuddy.io/invocation/6ddd4ea4-e6fd-44da-8a6b-770de4de2a55?actionDigest=8323378385c0c4f022e58b221c52a0b7eac0af87d5a4fc965897b2895b512b71#action) it seems to have used a single cached action, which has two files available: the object file, and the dependency file (inflate.d). The dependency file includes the paths that the build is complaining about (starting with c:/_bzl/33jjwvv5/execroot/).

The dirname after _bzl is the output directory name which is computed from the location of the workspace. I just tried to reproduce it (successfully) here: #2345

The difference between the CI run on master and the PRs is that the latter are created from a fork. So somehow that leads to a change of the workspace hash and a mismatch between expected include paths.

@avdv avdv merged commit b9a3b0c into tweag:master Oct 7, 2025
108 of 114 checks passed
@mergify mergify bot removed the merge-queue merge on green CI label Oct 7, 2025
@avdv
Copy link
Member

avdv commented Oct 7, 2025

I just merged the changes manually, thanks again @ilya-bobyr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants