feat(ghc): add GHC 9.10.3 support for ARM64 macOS #2359
Conversation
Add support for GHC 9.10.3 on ARM64 macOS platform: - Add stackage snapshot using LTS 24.19 - Update CI workflow to test GHC 9.10.3 on supported platforms - Exclude Windows and bzlmod for 9.10.3 (consistent with other recent GHC versions) The GHC 9.10.3 bindist configuration already exists in ghc_bindist_generated.json. Co-Authored-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
lexfrei
force-pushed
the
feat/add-ghc-9.10.3-arm64-macos
branch
from
5e90581 to
0aee9b8
Compare
GHC 9.10.3 is not available in the current nixpkgs pin (2024-07-02). Exclude it from test-nixpkgs job while keeping bindist tests which work. Co-Authored-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
Add generated stackage snapshot JSON files for GHC 9.10.3: - stackage_snapshot_9.10.3.json in root and rules_haskell_tests/ - Additional test snapshot YAML files (ghcide, pinning-test) - Update test_haddock.bzl with expected values for GHC 9.10.3 Also add CLAUDE.md with project guidance for Claude Code. Co-Authored-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
avdv
left a comment
avdv
left a comment
There was a problem hiding this comment.
Thank you, that looks good!
The only real error on CI (apart from the ones due to haskell/hackage-server#1366 and because of #2346) is this:
ERROR: /Users/runner/work/rules_haskell/rules_haskell/rules_haskell_tests/tests/ghcide/BUILD.bazel:5:9: no such package '@ghcide-exe//ghcide': no such package '@ghcide//': Not a regular file: /Users/runner/work/rules_haskell/rules_haskell/rules_haskell_tests/ghcide-snapshot_9.10.3.json and referenced by '//tests/ghcide:ghcide'
You need to run GHC_VERSION=9.10.3 bazel @ghcide-unpinned//:pin and commit the ghcide-snapshot_9.10.3.json file.
Fix ghcide-stack-snapshot_9.10.3.yaml to use correct nightly resolver (nightly-2024-12-11 instead of non-existent nightly-2024-12-10) and add missing lsp and lsp-types packages. Generate ghcide-snapshot_9.10.3.json for GHC 9.10.3 test support. Co-Authored-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
|
@avdv Thanks for the review! Fixed and pushed. The
|
Thanks, that makes sense. I just pushed some changes to use an lts revision instead of a nightly and pinned the two other snapshots. Hopefully, these will succeed now. 🤞 |
2 participants
Summary
Add support for GHC 9.10.3 across supported platforms (Linux and macOS).
Changes
stackage_snapshot_9.10.3.yamlwith LTS 24.19 resolverrules_haskell_tests/for test snapshotNotes
The GHC 9.10.3 binary distributions already exist in
ghc_bindist_generated.jsonfor all platforms (darwin_amd64, darwin_arm64, linux_amd64, linux_arm64, windows_amd64).Windows and bzlmod support excluded following the pattern of GHC 9.6.5 and 9.8.2.
Test Plan