-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provides caching for the linker #498
Merged
Merged
Changes from 20 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
40fe1c9
Create class _CachedEpydocLinker
7f0e1b0
Introduce Documentable.docstringlinker
783b7c7
Use the cached version of the linker all the time and refactor the ca…
157e16f
docs
1076985
Fix bug
98b7ed8
Fix mypy
e16e4a1
docs
0721175
add a test for the linker
cbd4ab5
Fix bug and add test
3464297
add docs
401eccc
Adjust linker to cache even more, do not clone tags when they don't n…
56163ce
Typo
69347a7
Get cache only once
87cec24
Add more tests and discover that there is still an little issue with …
ab00164
Fix issue with warnings
f56a0b7
Avoid changing _EpydocLinker interface and add few docs
6c759f1
add docs
d564b1a
Fix mypy
bd2e2b7
Remove unused import
158bb2e
Refactor to minimize code duplication
8a9a9b0
Bit of refactoring.
04e5b22
Merge branch 'master' into linker-cache
tristanlatr 11f0f4a
Fix format
tristanlatr e01cbf1
Merge branch 'linker-cache' of github.com:tristanlatr/pydoctor into l…
tristanlatr cbe1b85
Add code comment
tristanlatr 3f0c6df
Merge commit 'c367d216e7a16daa18b1d2216d0cb1976cbf7bdf' into linker-c…
411ae79
Add changelog entry
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best would be to avoid this workaround cyclic imports.
In order to do that, we should move all code related to the concrete docstring linkers in a new module:
docstringlinker.py
. I wonder if this change should happen in this PR though ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better for a separate PR, but also add all this info in a code comment :)