Smells like subtests

twm · Jan 11, 2025 · 2ab7fc5 · 2ab7fc5
1 parent b12ede1
commit 2ab7fc5
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/yarrharr/tests/test_views.py b/yarrharr/tests/test_views.py
@@ -121,19 +121,17 @@ def test_login_redirect(self):
             "/article/1234/",
         ]
 
-        redirects = []
         for next_ in nexts:
-            response = c.post(
-                "/login/",
-                {
-                    "next": next_,
-                    "username": "james",
-                    "password": "hunter2",
-                },
-            )
-            redirects.append(response["Location"])
-
-        self.assertEqual(nexts, redirects)
+            with self.subTest("login", next=next_):
+                response = c.post(
+                    "/login/",
+                    {
+                        "next": next_,
+                        "username": "james",
+                        "password": "hunter2",
+                    },
+                )
+                self.assertEqual(next_, response["Location"])
 
 
 class LabelListTests(TestCase):