Rework favicon rasterization #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
twm
commented
Jan 5, 2025
twm
commented
- Replace optipng with pyoxipng
- Generate an internally-compressed .ico
- Add a 128x128 .ico sprite
Avoid spawning a subprocess and installing an OS package.
Rather than using icotools to generate an uncompressed .ico file (which contains ~BMP images internally), generate one with embedded PNGs. This is a few hundred bytes larger than the result of applying Brotli over-the-top of the uncompressed .ico, but will enable embedding a larger icon. As a side effect, icotools (last release: 2018-03-07) is no longer required.
Cost: 3,722 bytes → 7,290 bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.