Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): run git auto commit hook before ask commit message #4257

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

qianlongzt
Copy link
Contributor

@qianlongzt
Copy link
Contributor Author

@twpayne I have no idea why the commit message check failed. Should I fix the commit message or the commit message check?

According to https://www.conventionalcommits.org/en/v1.0.0/ , words starting with lowercase in the description are accepted, and the scope should be accepted as anything other than feat.

The test-macos-2 failure doesn’t seem related to this change, does it?

@twpayne
Copy link
Owner

twpayne commented Feb 5, 2025

Should I fix the commit message or the commit message check?

Please fix the commit message. In this case, the commit message should be:

fix: Run git auto commit hook before creating commit message

The test-macos-2 failure doesn’t seem related to this change, does it?

Correct. Unfortunately macOS tests on GitHub's infrastructure are flaky and occasionally time out. I have no idea why, and suspect that the problem is with GitHub not chezmoi.

@qianlongzt qianlongzt force-pushed the fix-gitautocommit-hook-order branch from b5642f8 to 2cce243 Compare February 5, 2025 12:59
@qianlongzt
Copy link
Contributor Author

I updated the commit message.

@twpayne twpayne merged commit 6325123 into twpayne:master Feb 5, 2025
32 checks passed
@twpayne
Copy link
Owner

twpayne commented Feb 5, 2025

Thanks!

@qianlongzt qianlongzt deleted the fix-gitautocommit-hook-order branch February 5, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants